Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue Tests #1002

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Queue Tests #1002

merged 3 commits into from
Feb 1, 2019

Conversation

mehnadnerd
Copy link
Contributor

Type of change: feature request

Impact: no functional change

Development Phase: Implementation

Release Notes
Tests for Queues.

@mehnadnerd mehnadnerd requested a review from a team as a code owner January 25, 2019 21:41
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems sane to me, maybe others have some comments

@edwardcwang edwardcwang merged commit 30fd368 into chipsalliance:master Feb 1, 2019
@seldridge seldridge mentioned this pull request Jan 30, 2020
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
This avoids an apparent problem somewhere in sbt and/or scalatest
where the JVM runs out of metaspace if you repeatedly run tasks. This
is an annoyance for FIRRTL developers or users that keep an sbt
session open. This kludges around that by forking all tasks into a
separate JVM.

Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants